Include slow tests in local coverage#299
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 41 41
Lines 2545 2545
Branches 365 365
=======================================
Hits 2538 2538
Misses 2 2
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
left a comment
benoit74
left a comment
There was a problem hiding this comment.
I don't think it is the right fix at all for two reasons.
First CI already runs with --runslow --runinstalled flags
But coverage is still "only" at 99% in https://github.com/openzim/python-scraperlib/actions/runs/24666505316/job/72125521954 (last CI run on main branch):
This 99% is the problem which needs to be fixed.
And we intentionally do not set flags in the invoke tasks so that users can choose to run with or without them. If we include the flags in invoke tasks, then there is no way to not run slow tests for instance.
Do I miss something or should we close this PR?
My apologies. I misunderstood the problem. The contribution section said to run I will close this PR. Sorry for the inconvenience. @benoit74 |
|
No problem, misunderstandings is expected and normal. |
2 participants
Fixes #293
The coverage shown was incorrect when running
invoke coveragelocally, as the slow tests were skipped. Adding--runslowflag ensures slow tests run properly before reporting coverage locally.